Fix CloudRunExecuteJobOperator logging links in deferred mode#56234
Closed
steveahnahn wants to merge 1 commit intoapache:mainfrom
Closed
Fix CloudRunExecuteJobOperator logging links in deferred mode#56234steveahnahn wants to merge 1 commit intoapache:mainfrom
steveahnahn wants to merge 1 commit intoapache:mainfrom
Conversation
2 tasks
Contributor
|
Hello @steveahnahn ! |
Contributor
Author
|
Thanks @MaksYermak for the info, closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fix
ValueError: dictionary update sequence element #0 has length 1; 2 is required errorwhen using CloudRunExecuteJobOperator with deferrable=True. The issue occurred because XCom data serialization in deferred execution sometimes stores logging link data as strings instead of dictionaries, causing BaseGoogleLink.get_config() to fail when attempting dict updatesSolution
Modified BaseGoogleLink.get_config() to handle both string and dictionary XCom values
Testing
Added comprehensive unit test test_get_config_with_string_xcom_value covering:
- String XCom values
- Dictionary XCom values
- None XCom values
Related Issue:
closes: #55996